Removes existing GitLab Duo banners targeting owner/admins
What does this MR do and why?
We're going to be creating new Duo enablement banners. This MR is removing the old banners and tracking events to give our users a break prior to the rollout of the new banners / to avoid overwhelming folks with banners.
References
- !188312 (merged) (merged)
- !189055 (merged) (diffs)
- Original Issue
Screenshots or screen recordings
- Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
|
Expect to not see banner / see page as normal. |
How to set up and validate locally
I debated what to put here - ultimately you can verify this by executing the verification steps to see the old banner (with the stipulated Feature Flags and so on turned on) and see that the banners are no longer there.
Verify in .com
-
In rails console enable the feature flag
Feature.enable(:allow_duo_base_access) -
Visit a group's main page OR visit a group's duo settings page with the following qualifications:
- Paid
- User is an owner or admin
-
duo_core_features_enabledisn't already enabled (this is a namespace setting - if you need to disable it you can run:group = Group.find(group_id); group.namespace_settings.update(duo_core_features_enabled: false);) - Banner hasn't already been dismissed
-
Banner should not show
Verify in Self-Managed:
- Make sure your local GDK has a license and not simulating SaaS: https://gitlab.com/gitlab-org/customers-gitlab-com/-/blob/main/doc/setup/gitlab.md#adding-a-license-from-staging-customers-portal-to-your-gdk
- Comment out the date condition by applying this diff:
-
Click to expand *
diff --git a/ee/app/helpers/ee/users/callouts_helper.rb b/ee/app/helpers/ee/users/callouts_helper.rb index b585a78c9860..0ad1938e6914 100644 --- a/ee/app/helpers/ee/users/callouts_helper.rb +++ b/ee/app/helpers/ee/users/callouts_helper.rb @@ -74,8 +74,8 @@ def show_transition_to_jihu_callout? end def show_enable_duo_banner_sm?(callouts_feature_name) - Date.current >= DUO_CORE_RELEASE_DATE && - ::Feature.enabled?(:allow_duo_base_access, :instance) && + # Date.current >= DUO_CORE_RELEASE_DATE && + ::Feature.enabled?(:allow_duo_base_access, :instance) && ::Feature.enabled?(:show_enable_duo_banner_sm, :instance) && current_user.can_admin_all_resources? && License.duo_core_features_available? &&
- Enable feature flag in rails console:
Feature.enable(:allow_duo_base_access) - Sign in as admin
- Visit
/adminand/admin/gitlab_duo- expect to not see the banners
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #562191 (closed)




