Skip to content

Consolidated expectations into fewer create_pipeline_service/rules specs

drew stachon requested to merge rules-specs-consolidation into master

What does this MR do?

This is a follow-up to a recently merged MR that condenses some expectations about validity and invalidity into single specs. There's not a great reason to keep them separate, and this implementation runs quite a bit faster, while making the exact same assertions in each context.

Results

drews-MacBook-Pro-2:gitlab drew$ git checkout master
Switched to branch 'master'
Your branch is up to date with 'upstream/master'.
drews-MacBook-Pro-2:gitlab drew$ bundle exec rspec /Users/drew/gitlab/gdk/gitlab/spec/services/ci/create_pipeline_service/rules_spec.rb
....................................

Finished in 43.74 seconds (files took 25.44 seconds to load)
36 examples, 0 failures

drews-MacBook-Pro-2:gitlab drew$ git checkout rules-specs-consolidation 
Switched to branch 'rules-specs-consolidation'
drews-MacBook-Pro-2:gitlab drew$ bundle exec rspec /Users/drew/gitlab/gdk/gitlab/spec/services/ci/create_pipeline_service/rules_spec.rb
.....................

Finished in 13.62 seconds (files took 21.36 seconds to load)
21 examples, 0 failures

drews-MacBook-Pro-2:gitlab drew$

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports