Skip to content

Add Sidekiq middleware stack integration tests

Andrew Newdigate requested to merge sidekiq-middleware-integration-tests into master

What does this MR do?

Before this change, Sidekiq middleware components were only tested through unit tests. No integration testing of Sidekiq middleware components was done.

This state of affairs led to this change passing all tests and being merged into master: !19491 (merged)

Due to a type error, the change did not work, but without integration tests, this was only discovered when it was deployed to dev.gitlab.org, where it broke all background processing jobs.

This change adds basic integration tests for our server-side and client-side middleware stacks, to ensure that messages pass through the stack without causing exceptions.

The change also ensures that each middleware yields control as expected.

cc @DylanGriffith @engwan

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Mayra Cabrera

Merge request reports