The source project of this merge request has been removed.
WIP: Correct number of Merge Request approvals is shown
What does this MR do?
This MR will ensure that the correct number of approvals (given and required) is shown.
The displayed number of Merge Request approvals can be incorrect. This behavior is not consistent.
For example, the number of approvals shown is: 1 of 0 when the expected number of approvals required is 2.
What are the relevant issue numbers?
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team