Skip duplciates check for large table
What does this MR do and why?
Skip duplciates check for large table
Skips duplicate check for the index corruption, if the table size is large than configured max table size
References
Screenshots or screen recordings
How to set up and validate locally
-
Checkout the branch
-
Apply the patch
git apply <<'EOF' diff --git a/lib/gitlab/database/collation_checker.rb b/lib/gitlab/database/collation_checker.rb index cc943cbb3ac6..2dcd05bb5098 100644 --- a/lib/gitlab/database/collation_checker.rb +++ b/lib/gitlab/database/collation_checker.rb @@ -6,7 +6,7 @@ class CollationChecker include Gitlab::Database::Migrations::TimeoutHelpers # Maximum table size in bytes for running duplicate checks - MAX_TABLE_SIZE_FOR_DUPLICATE_CHECK = 1.gigabyte + MAX_TABLE_SIZE_FOR_DUPLICATE_CHECK = 0.gigabyte COLLATION_VERSION_MISMATCH_QUERY = <<~SQL SELECT EOF -
Visit the admin page: http://gdk.test:3000/admin/database_diagnostics
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Bishwa Hang Rai
