Step-up auth: Rename rejected? to failed? in step-up authentication flow (!201328) · Merge requests · GitLab.org / GitLab

Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.

What does this MR do and why?

Step-up auth: Rename rejected? to failed? in step-up authentication flow

This commit improves the clarity of the step-up authentication API by renaming the rejected? method to failed? for better semantic consistency with the STATE_FAILED constant.

Changes:

Rename StepUpAuthenticationFlow#rejected? to #failed?
Add StepUpAuthentication.failed_step_up_auth_flows helper method
Update all test references to use the new method name
Add comprehensive test coverage for failed authentication flows

The renaming aligns the method name with the internal state representation and improves API consistency across the authentication flow lifecycle.

Changelog: other

🛠️ with ❤️ at Siemens

References

Follow-up to the initial step-up auth MR: Step-up auth: Add omniauth step-up auth for adm... (!171643 - merged)

Screenshots or screen recordings

Only refactoring changes

How to set up and validate locally

Run the affected test

bundle exec rspec spec/lib/gitlab/auth/oidc/step_up_authentication_flow_spec.rb

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

MR Checklist (@gerardo-navarro)

Related to #474650

Edited Aug 13, 2025 by 🤖 GitLab Bot 🤖