Skip to content

Exclude deleted projects from job token authorization logs graphql and csv export service backport to 18.2

Related: https://gitlab.com/gitlab-org/gitlab/-/issues/560082

What does this MR do and why?

This is a backport into %18.2 - !200900 (merged)

Since the background job responsible for handling the foreign key on ci_job_token_authorizations runs asynchronously and with some delay, the UI for CiJobTokenAuthLog can appear broken in the meantime.

As a result, the GraphQL query for auth logs fails with the error: "Cannot return null for non-nullable field CiJobTokenAuthLog.originProject"

This MR does the following:

  • Excludes deleted or non-existent projects from JobTokenAuthLogsResolver.
  • Excludes deleted or non-existent projects from Ci::JobToken::ExportAuthorizationsService used for the CSV download link.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Dmytro Biryukov

Merge request reports

Loading