Backport bug - Fix mutations of frozen object in feature_setting.rb
What does this MR do and why?
This change fixes a bug in the AI feature settings code that was accidentally modifying shared data. The main fix changes the code to create a copy of the feature list before making changes to it, preventing unintended side effects. The testing was also improved by setting better default values and adding more comprehensive test cases to ensure the feature filtering works correctly under different conditions (like when users have or haven't accepted testing terms, and for premium license holders). This makes the code more reliable and prevents potential issues where one part of the system could accidentally affect another.
Backport of !200946 (merged)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). -
The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post. -
Required labels have been applied to this merge request -
severity label and bug subtype labels (if applicable) -
If this MR fixes a bug that affects customers, the customer label has been applied.
-
-
Set the milestone of the merge request to match the target backport branch version. -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:test-on-omnibus-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only). - Once the backport has been merged, the commit changes will be automatically deployed to a release environment that can be used for manual validation. See after merging runbook for details.
Related to #560746 (closed)