Skip to content

Danger to not error when e2e:test-on-omnibus-ee job not present for only QA changes

Jenny Kimrequested to merge
jk/danger-stable-allow-backport-qa into master

What does this MR do and why?

As title indicates, this change makes Danger not error out when e2e:test-on-omnibus-ee job isn't present on MRs with only QA changes, as discussed in !199222 (comment 2653079851).

It also prevents messages like this to be output by the Danger bot in the same scenario.

The allowed_backport_changes? is referred to in encourage_package_and_qa_execution?, which is used to trigger the message in https://gitlab.com/gitlab-org/gitlab/-/blob/master/danger/stable_branch_patch/Dangerfile#L3

  ## `e2e:test-on-omnibus-ee`

  **@#{helper.mr_author}, the `e2e:test-on-omnibus-ee` job must complete before merging this merge request.***

  If the `e2e:test-on-omnibus-ee` pipeline fails and you're unable to diagnose the issue, request assistance in the
  `#s_developer_experience` Slack channel to confirm that the failures are unrelated to the merge request.

After merge, we should backport this to maintained stable branches.

References

Ref: gitlab-com/gl-infra/delivery#21388 (closed)

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jenny Kim

Merge request reports