Skip to content

MR approval placeholders same size as images

Simon Knox requested to merge 2491-approval-align into master

What does this MR do?

Fix Approvers layout bug remove some unused styles (e.g. > span where span had changed)

Are there points in the code the reviewer needs to double check?

  • Are the circles correct size? They are bigger than the "available approvers" ones above, and smaller than the Pipeline status icons. That's a lot of different sized circles
  • I moved SVG placeholder stuff into link_to_member_avatar.js (see screenshots). Seemed to be passing a lot of props for no reason, unless there are other SVGs used for that image.

Why was this MR needed?

regression

Screenshots (if relevant)

Screen_Shot_2017-05-31_at_2.51.49_pm_copy

Default image placeholder behaviour

Old - broken image was squircle:

Screen_Shot_2017-05-31_at_5.29.15_pm_copy

New, broken image is placeholder:

Screen_Shot_2017-05-31_at_5.27.37_pm_copy

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #2491 (closed)

Edited by Simon Knox

Merge request reports