Add FK constraint (NOT VALID) to approval_merge_request_rules_users#project_id

Tomasz Skoruparequested to merge
tskorupa/add_not_valid_foreign_key_to_amrruo_on_project_id into master

What does this MR do and why?

  1. Add index to approval_merge_request_rules_users#project_id (follow up to https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/post_migrate/20250304132249_prepare_index_approval_merge_request_rules_users_on_project_id.rb) according to https://docs.gitlab.com/development/database/adding_database_indexes/#create-indexes-asynchronously
  2. Add FK constraint (NOT VALID) to approval_merge_request_rules_users#project_id

Addresses #560322 (closed)

References

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tomasz Skorupa

Merge request reports