Skip to content

Fix style-lint errors and warnings for profile.scss

What does this MR do?

This MR resolves the style-lint errors and warnings for profile.scss.

Before:

app/assets/stylesheets/pages/profile.scss
 126:3   ⚠  ".description" has the same properties as our BS4 utility class ".text-truncate (1853:1)" so please use that   stylelint-gitlab/utility-classes    
            instead.                                                                                                                                           
 138:3   ⚠  "a" and ".account-btn-link, .profile-settings-sidebar a, .settings-sidebar a                                   stylelint-gitlab/duplicate-selectors
            (/Users/jiaan/Projects/gitlab-development-kit/gitlab/app/assets/stylesheets/pages/profile.scss -20:1)" have                                        
            the same properties.                                                                                                                               
 327:7   ⚠  Expected ".user-callout .landing .close .dismiss-icon" to have no more than 3 compound selectors               selector-max-compound-selectors     
 337:9   ⚠  Expected nesting depth to be no more than 3                                                                    max-nesting-depth                   
 337:9   ⚠  Expected ".user-callout .landing .close:hover .dismiss-icon" to have no more than 3 compound selectors         selector-max-compound-selectors     
 347:7   ⚠  Expected ".user-callout .landing .svg-container svg" to have no more than 3 compound selectors                 selector-max-compound-selectors     
 355:9   ⚠  Expected nesting depth to be no more than 3                                                                    max-nesting-depth                   
 355:9   ⚠  Expected ".user-callout .landing .svg-container.convdev svg" to have no more than 3 compound selectors         selector-max-compound-selectors     
 381:9   ⚠  Expected ".user-callout .landing .svg-container svg" to have no more than 3 compound selectors                 selector-max-compound-selectors     
 381:9   ⚠  Expected ".user-callout .landing .user-callout-copy svg" to have no more than 3 compound selectors             selector-max-compound-selectors     
 388:11  ⚠  Expected ".user-callout .landing .svg-container.convdev svg" to have no more than 3 compound selectors         selector-max-compound-selectors     
 388:11  ⚠  Expected ".user-callout .landing .user-callout-copy.convdev svg" to have no more than 3 compound selectors     selector-max-compound-selectors     
 403:3   ⚠  "a" and "&.not-active                                                                                          stylelint-gitlab/duplicate-selectors
            (/Users/jiaan/Projects/gitlab-development-kit/gitlab/app/assets/stylesheets/pages/profile.scss -173:3)" have                                       
            the same properties.                                                                                                                               
 442:3   ⚠  ".form-group > label" and ".scope-name                                                                         stylelint-gitlab/duplicate-selectors
            (/Users/jiaan/Projects/gitlab-development-kit/gitlab/app/assets/stylesheets/pages/profile.scss -295:3)" have                                       
            the same properties.                                                                                                                               
 457:7   ⚠  "svg" and "svg (/Users/jiaan/Projects/gitlab-development-kit/gitlab/app/assets/stylesheets/pages/profile.scss  stylelint-gitlab/duplicate-selectors
            -437:5)" have the same properties.                                                                                                                 
 457:7   ⚠  Expected ".edit-user .emoji-menu-toggle-button .no-emoji-placeholder svg" to have no more than 3 compound      selector-max-compound-selectors     
            selectors

After:

$ yarn run stylelint-file app/assets/stylesheets/pages/profile.scss
yarn run v1.19.1
$ node node_modules/stylelint/bin/stylelint.js app/assets/stylesheets/pages/profile.scss

Screenshots

Profile page

Touched the form labels.

Before After
image image

Profile -> SSH Keys page

Touched the link colour and SSH key list description at the bottom.

Before After
image image

Profile -> GPG Keys page

Touched the link colour and key list description at the bottom.

Before After
image image

Pipeline Schedules callout

Touched the SVG style in for the user callout.

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Closes #27796 (closed)

Edited by Jiaan Louw

Merge request reports

Loading