Removing check for project and framework for self managed instances
What does this MR do and why?
As discussed in issue https://gitlab.com/gitlab-org/gitlab/-/issues/560032 comment https://gitlab.com/gitlab-org/gitlab/-/issues/560032#note_2671656658, we decided to skip the check for project and framework belonging to same root namespace on dedicated/self managed gitlab instances. See issue description for more clarity.
References
https://gitlab.com/gitlab-org/gitlab/-/issues/560032 https://gitlab.com/gitlab-org/release/tasks/-/issues/20720
How to set up and validate locally
- You need to have 2 groups with Ultimate license.
- Create a compliance framework inside first group.
- Create a project inside second group.
- For simulating Gitlab.com make the method Gitlab.com? to return true in your local code, so the following graphql should not allow the framework to be associated with the project.
mutation setFrameworkToProject {
projectSetComplianceFramework(
input: {
projectId: "gid://gitlab/Project/<project_id>",
complianceFrameworkId: "gid://gitlab/ComplianceManagement::Framework/<framework_id>"
}
) {
errors
}
}
- For simulating self managed instance make the method Gitlab.com? to return false in your local code, so the following graphql should allow the framework to be associated with the project.
mutation setFrameworkToProject {
projectSetComplianceFramework(
input: {
projectId: "gid://gitlab/Project/<project_id>",
complianceFrameworkId: "gid://gitlab/ComplianceManagement::Framework/<framework_id>"
}
) {
errors
}
}
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #560032
Edited by Hitesh Raghuvanshi