Adds pagination to maven virtual registries list page
What does this MR do and why?
Adds pagination to maven virtual registries list page
Replace REST API with GraphQL query
Handles URL params & browser back button
EE: true
References
- Note: We can only create maximum number of 20 virtual registries see: https://gitlab.com/gitlab-org/gitlab/-/blob/729e0d85b65b1974f88896ffeb90c4a42aa13a5f/ee/app/models/virtual_registries/packages/maven/registry.rb#L7
Screenshots or screen recordings
| Before | After |
|---|---|
![]() |
![]() |
How to set up and validate locally
- Ensure you have enabled the following feature flags
$ gdk rails console
Feature.enable(:maven_virtual_registry)
Feature.enable(:ui_for_virtual_registries)
- Go to a top-level group
- Create 20 virtual registries
g = Group.find(<root-group-id>)
20.times.each { |i| VirtualRegistries::Packages::Maven::Registry.create(group: g, name: "maven registry #{i}") }
- Go to
Deploy -> Virtual Registry -> Maven - Apply diff to see pagination by 5 items since default is 20 & the limit is 20:
diff --git a/ee/app/assets/javascripts/packages_and_registries/virtual_registries/maven/registries_list_app.vue b/ee/app/assets/javascripts/packages_and_registries/virtual_registries/maven/registries_list_app.vue
index 3feb3186fe5b..209f0a664561 100644
--- a/ee/app/assets/javascripts/packages_and_registries/virtual_registries/maven/registries_list_app.vue
+++ b/ee/app/assets/javascripts/packages_and_registries/virtual_registries/maven/registries_list_app.vue
@@ -7,7 +7,7 @@ import MavenRegistryItem from 'ee/packages_and_registries/virtual_registries/com
import getMavenVirtualRegistries from '../graphql/queries/get_maven_virtual_registries.query.graphql';
import { captureException } from '../sentry_utils';
-const PAGE_SIZE = 20;
+const PAGE_SIZE = 5;
export default {
name: 'MavenRegistriesListApp',
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #559044 (closed)
Edited by Rahul Chanila

