Fix flaky note scope spec

What does this MR do and why?

This scope does not work across noteable types because the ID sequences are different

References

• #554692 (closed)

How to set up and validate locally

RAILS_ENV=test bundle exec rails db:reset
bin/rspec ./ee/spec/models/note_spec.rb:589

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.