[BUG] Hide Duo Seat Utilization and Duo Availability Sections in SaaS Admin Instance Settings
What does this MR do and why?
Hides Duo seat utilization and Duo availability from the SaaS admin instance menu where they are currently visible (and broken). They shouldn't be there at all.
Related issue: #559002 (closed)
Changes in this MR:
- Hide Duo seat utilization and Duo availability in SaaS admin instance settings. A new prop
isAdminInstanceDuoHomeis added to help with determining when in admin settings (in SaaSGitlabDuoHomeis shared between admin and group settings) - Replace usage of hard-coded
showDuoWorkflowSettingsprop withisAdminInstanceDuoHome(for a more meaningful understanding of when to show workflow settings) - Refactors
gitlab_duo_home_spec.jsfor greater readability
References
Screenshots or screen recordings
SaaS admin instance Duo home page
| Before | After |
|---|---|
BrokenSaasDuoAdmin
|
![]() |
How to set up and validate locally
Set-up
- An active online cloud, legacy or offline Ultimate license.
Validating SaaS settings
- Start GDK in saas mode
GITLAB_SIMULATE_SAAS=1 gdk startto validate saas settings - Navigate to the SaaS instance settings home page -
http://gdk.test:3000/admin/gitlab_duoand ensure the Duo seat utilization and availability screen are not there (see "After" screenshot) - Run the Duo setup rake task
GITLAB_SIMULATE_SAAS=1 bundle exec 'rake gitlab:duo:setup'to seed DB with a Duo test group (it's calledgitlab-duo). - Navigate to the test group's Duo settings page
http://gdk.test:3000/groups/gitlab-duo/-/settings/gitlab_duo. It should look like the "SaaS Duo group settings" screengrabs (no regressions)
Validating self-managed settings
- Start GDK in self-managed mode
GITLAB_SIMULATE_SAAS=0 gdk restartto validate self-managed settings - Navigate to the self-managed instance settings home page -
http://gdk.test:3000/admin/gitlab_duoand ensure the Duo seat utilization and availability screen are there. It should look like the "Self-managed admin instance Duo home page screen" screengrabs (no refressions). Don't worry if you are missing the "GitLab Duo Self-Hosted" section, this requires seperate configuration and is unrelated. - Navigate to the Duo settings page of the test group set up previously -
http://gdk.test:3000/groups/gitlab-duo/-/settings/gitlab_duo. It should look like the "Self-managed Duo group settings" screengrabs (no regressions)
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Julie Huang







