Skip to content

Make GraphQL enums a little bit nicer

Mario de la Ossa requested to merge make_graphql_enums_slightly_nicer into master

What does this MR do?

Just a tiny improvement so our GraphQL enum usage can look a bit tidier:

Adds an enum method to GraphQL enums that works pretty much the same as ActiveRecord enum's pluralized value holder method.

Example: Given a GraphQL enum class defined as such:

module Types
  class AnEnum < BaseEnum
    graphql_name 'An'
    description 'AnEnum'

    value 'TEST', 'A test?', value: 3
    value 'other'
    value 'NORMAL'
  end
end
[9] pry(main)> Types::AnEnum.enum
=> {"test"=>3, "other"=>"other", "normal"=>"NORMAL"}
[10] pry(main)> Types::AnEnum.enum[:test]
=> 3
[11] pry(main)> Types::AnEnum.enum[:normal]
=> "NORMAL"

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports