Fix nested group expansion in Your Work > Groups Inactive tab
What does this MR do and why?
When expanding a group in the Inactive tab, we incorrectly send a request with active=true parameter to load its subgroups.
This MR fixes the issue by removing the active parameter when expanding inactive groups, allowing inactive subgroups to be retrieved.
Note: We don't use active=false to load inactive subgroups because of its special behavior in the endpoint. It preloads the parents of the subgroups again which collides with the existing list. Having no active parameter ensures we only load subgroups one-level below.
References
Related to #557854 (closed)
Screenshots or screen recordings
| Before | After |
|---|---|
| Screen_Recording_2025-07-29_at_3.44.33_PM | Screen_Recording_2025-07-29_at_4.22.23_PM |
How to set up and validate locally
- Create 20 groups with names starting with
a. - Create a subgroup with a name that starts with
b. - Mark the 20 groups for deletion (you may also archive them but you must enable
archive_groupfeature flag first). - Go to
/dashboard/groups/inactiveand sort byNamein ascending order. - Expand an inactive group with subgroups.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Shane Maglangit