Skip to content

Fixes issue with email not being sent on service account email update

Shilpa Kundapurrequested to merge
557585-patch-api-service-account-email-send-confirmation-email into master

What does this MR do and why?

The PATCH endpoints to update an instance or group level service account email set the unconfirmed email when email confirmation is required. They were however not sending the actual confirmation email to the user, due to permission checks on receive_notifications. With this MR, a new permission called receive_confirmation_instructions is introduced since some of the rules for confirmation emails are different from general notifications.

References

#557585 (comment 2653085382)

Screenshots or screen recordings

NA

How to set up and validate locally

  1. Switch to the current branch
  2. Update the email for a newly created group service account using `PATCH http://gdk.test:3000/api/v4/groups//service_accounts/
  3. Navigate to LetterOpener and confirm that you see a "Confirmation instructions" email
  4. Do the same for an instance service account using `PATCH http://gdk.test:3000/api/v4/service_accounts/

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #557585 (closed)

Merge request reports