Allow empty telltale lists in Users::ArkoseSession

Ruby Nealonrequested to merge
rubynealon/arkose-allow-empty-telltale-list into master

What does this MR do and why?

Removes the presence validation for telltale_list in Users::ArkoseSession which prevents the creation of valid sessions with no telltales. This has prevented otherwise valid sessions for users from being recorded (elastic query).

References

How to set up and validate locally

  1. Modify ee/spec/fixtures/arkose/successfully_solved_ec_response.json to make session_details.telltale_list an empty array.
  2. Re-run the spec confirming that sessions can be created bundle exec rspec ee/spec/models/users/arkose_sessions_spec.rb

We cannot control the telltale_list in Arkose responses so this is hard to test locally with an actual flow, even with the development Arkose instance setup properly.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports