Exclude release environments from QA live envs

Dat Tangrequested to merge
dattang/exclude-release-environments-qa-runtime-rule into master

What does this MR do and why?

Exclude release environments from QA live envs

This is the result of a discussion on how to fix Smoke tests on Release Environments https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/21273#note_2644281109.

The method running_on_release? is intended to detect the release instance with the URL release.gitlab.net, and treat it as a live environment - a fixed environment providing tokens and credentials to QA

Nowadays we have Release Environments with their domains ending with env.release.gitlab.net. They are ephemeral environments (in the sense that they are created on-request automatically and don't live forever). Thus, this change makes the string matches explicitly.

References

Ref:

Testing

I tested by using the QA image of this MR running against one of the Release Environments (I use my test project https://gitlab.com/dat.tang.gitlab/test-gitlab-ci/-/jobs/10776211591). The smoke tests don't ask for accounts anymore, which mean they don't treat Release Environments as live environments anymore, which is exactly what we expect. (The test still failed though, apparently because the QA image is for master while the RE is on a stable branch)

Edited by Dat Tang

Merge request reports