Skip to content

Add committer email to commit response

Hunter Stewartrequested to merge
550367-add-unmailmapped-committer into master

Why

We need to use the unmailmapped committer email from the GetCommitSignatures response to determine if the commit committer email has changed from when the commit was verified.

What

Add the unmailmapped committer email from the GetCommitSignatures response to the signatures object in Gitlab rails.

Resolves #550367 (closed)

Local verification

  • in GDK, create a signed commit

  • in rails console, find the signed commit and it's project

  • initialize a client: client = Gitlab::GitalyClient::CommitService.new(project.repository)

  • pass the commit id: client.get_commit_signatures([commit_id])

  • you should see hash that includes :committer_email=>"" as a key value pair

  • enable the feature flag: Feature.enable(:committer_email)

  • execute the same line again: `client.get_commit_signatures([commit_id])

  • you should see hash that includes :committer_email=>"your-committer-email@example.com" as a key value pair

Edited by Hunter Stewart

Merge request reports