Skip to content

Danger: Skip counting fixup commits as quality of merge request

What does this MR do?

Danger CI was updated to skip fixup! and squash! commits, as those get removed before final merge: gitlab-foss!32210 (merged)

Now appears they are also counted for number of commits, which is not true.

This merge request skips counting those commits.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Elan Ruusamäe

Merge request reports