Skip to content

Add note to ping appsec in security MR template

Dylan Griffith requested to merge ping-appssec-security-workflow into master

What does this MR do?

This is documented in the developer workflow but it's easy to miss since it's not a step in the MR to be checked off https://gitlab.com/gitlab-org/release/docs/blob/master/general/security/developer.md#create-merge-requests . The developer workflow is also a little vague about "leave enough time to review" but it is not very explicitly stating that you should expect them to approve it so I've added that as a separate checkbox.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports