Skip to content

WIP: Install K3d on Specs Dockerfile

Dan Davison requested to merge qa-k3d-support into master

What does this MR do?

Smaller iteration of !17562 (closed)

  • Installs K3d on the qa/Dockerfile specs container used by gitlab-qa
  • Allows local connections on local development environments

A future iteration for the Public URL validator(s) could include flag to enable/disable this.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

The changing of url_blocker.rb and public_url_validator.rb change the hard-coded boolean to use the Rails environment.

We don't allow local connections when in Production mode, but we do allow local connections when running in a development or test environment

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

/cc @tigerwnz @gitlab-com/gl-security/appsec

Merge request reports