Permission check on variables
What does this MR do?
Currently, we are lacking of permission check on secret variables. If the pipeline is created on the project, the pipeline has full-permission to access all variables.
In fork-pipelines workflow, this is problematic because having an ability to create a pipeline is equal to having an ability to access to all resources. External users should just have a create a pipeline with restricted resource.
We need proper permission check to control resource access, even though the user has an ability to create a pipeline.
We should check user's permission if the user has an ability to read the variables.
Related #11934 (closed)
Permission check on variables
Here is the Variable categories and permissions
-
Ci::Build#*_variables...Ci::BuildPolicy#read_variables -
Ci::Pipeline#*_variables...Ci::PipelinePolicy#read_variables -
Ci::Runner#*_variables...RunnerPolicy#read_variables -
Clusters::Cluster#*_variables...ClusterPolicy#read_variables -
Clusters::KubernetesNamespace#*_variables...ClusterPolicy#read_variables -
Clusters::Platform::Kubernetes#*_variables...ClusterPolicy#read_variables -
Environment#*_variables...EnvironmentPolicy#read_variables -
ExternalPullRequest#*_variables...ExternalPullRequestPolicy#read_variables -
MergeRequest#*_variables...MergeRequestPolicy#read_variables -
ProjectAutoDevops#*_variables...ProjectAutoDevopsPolicy#read_variables -
Project#*_variables...ProjectPolicy#read_variables
Feature Flag
permission_check_on_variables
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team