Omit streaming token from helper methods syncing

Andrew Jungrequested to merge
andrew-jung/omit-protected-stream-token-header-in-helpers into master

What does this MR do and why?

Omit streaming token from helper methods syncing -- as we added model validation here: !193356 (merged)

This MR edits the temporary helpers to help sync the legacy <-> streaming tables to not add the streaming token header (as it was doing previously). The header is automatically added through concerns and not stored as part of the config or tables.

Changelog: added EE: true

References

Queries:

audit_events_streaming_headers: (same for instance_audit_events_streaming_headers table)

How to set up and validate locally

  • Enable this feature flag: audit_events_external_destination_streamer_consolidation_refactor (This enables the helper classes)
  • Navigate to an audit stream (instance or groups) page (ex: http://localhost:3000/groups/flightjs/-/audit_events?tab=streams)
  • Create a HTTP destination (can just have a name/url)
  • Enable the feature flag: use_consolidated_audit_event_stream_dest_api (This enables the new frontend for the new tables, the UI will be identical)
  • Refresh the page
  • The new destination should not have a header for X-Gitlab-Event-Streaming-Token
  • Try with creates/edits to various fields with/without feature flag
Edited by Andrew Jung

Merge request reports