Remove custom error component for Duo Enterprise Trial flow
What does this MR do and why?
Fixes: #546199 (closed)
We handled the Duo Pro variation in !189244 (merged) - to use the generic trial failure error. This PR is meant to do the same for the Duo Enterprise variation. Since now are using the default error message and not a custom error message for enterprise or pro, this MR removes the use case of the extra form component.
Was introduced in this discussion, here
Changelog: changed
EE: true
References
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Example:
- Setup GDK to simulate SaaS.
- Create a new group
- Make sure the group is on the
ultimate
plan. - In the codebase, make a small change to ensure we trigger the error message.
ee/app/controllers/concerns/gitlab_subscriptions/trials/duo_common.rb
def check_feature_available!
true
end
def check_trial_eligibility!
true
end
- Visit
/-/trials/duo_enterprise/new?step=trial
- Select the group that you created and press
Activate my trial
- This should give the error.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Anas Shahid