Skip to content

Resolve "images stopped loading: signed URLs of uploads expire earlier than redirect cache"

What does this MR do?

Setting a long-term cache header works fine when not using object storage, or when using object storage with proxy_download enabled. When using object storage without proxy_download, we send a redirect that's cached for six months to a signed URL in object storage, but the signed URL only works for ten minutes. So once those ten minutes are up, the browser will keep following the (cached) redirect to a dead link.

In future, we could be more sophisticated by setting the TTL based on the settings we're using. For now, just set this back to the pre-12.4 state of not caching content for longer than 5 minutes.

See #35337 (closed) and !18345 (merged). In the latter you can see that this was set to zero before 12.4.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Sean McGivern

Merge request reports