Adjust placement of "Milestone can be closed" alert
What does this MR do and why?
When all the issues in a milestone are closed, a success alert shows on the milestone page informing the user that the milestone can be closed.
This MR adjusts the placement of that alert to better comply with Pajamas guidance. It also changes the logic so that this alert is only shown to users who can actually take action to close a milestone.
References
- Semi-related to 'All issues for this milestone are closed.' mil... (#16243 - closed)
- ✂️ UX Paper Cuts 18.2 → USAT & bug::ux (#513103 - closed)
- https://design.gitlab.com/components/alert#placement
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- Check out this branch
- Find a milestone with only closed issues in it (if necessary, create one to achieve this state)
- Visit that milestone's details page
- The green "all issues for this milestone are closed..." alert will appear above the header content.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Chad Lavimoniere