Refactor environment controller spec
What does this MR do?
The logs endpoint in the environments controller previously served up our logs HTML page if the request used the HTML format and it served up k8s pod log content when using the JSON format.
!18950 (merged) separated the formats into 2 APIs, one for getting our logs HTML page, and another for requesting k8s pod log content.
This MR refactors the environments controller spec to reflect that the HTML and JSON response formats are now two different APIs. A lot of the changes in this MR are changes in indentation (for instance when examples were taken out of a context), so it might be useful to view this MR without whitespace changes (!19422 (diffs)).
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team