Skip to content

Implement feedback code review for GQ

What does this MR do and why?

This MR uses the existing duo chat feedback mechanism to provide a method of giving feedback for Amazon q /q quick actions. It has added two new key/value pairs to help track the specific instances of feedback:

  • EVENT_CATEGORY with a value of amazon_q_code_review_feedback
  • EVENT_ACTION with a value amazon_q

References

Spike issue for discovery and conversations regarding Gitlab downloading the reports and sharing them as needed: https://gitlab.com/gitlab-com/ops-sub-department/aws-gitlab-ai-integration/integration-motion-planning/-/issues/561

Development issue to implement code changes: https://gitlab.com/gitlab-com/ops-sub-department/aws-gitlab-ai-integration/integration-motion-planning/-/issues/577

Screenshots or screen recordings

Before After

image.png

image.png

image.png

image.png

How to set up and validate locally

  1. Pull the branch or build an RPM from the branch
  2. Since Amazon Q quick actions cannot be run locally in a gdk install, we will have to change line 416 of note_actions.vue from v-if="isAmazonQCodeReview && !feedbackReceived" to v-if="!feedbackReceived" so that we can test using a normal review comment.
  3. Leave feedback on an MR.
  4. From the overflow menu, select the "Provide feedback on code review" option.
  5. Confirm that the Duo Chat feedback modal shows up and leave feedback.
  6. Confirm that the feedback exists with the correct key/value pairs in tableau.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Matthew Ostovarpour

Merge request reports

Loading