Skip to content

Add "GET /groups/:id/saml_users" API endpoint

What does this MR do and why?

This MR adds GET /groups/:id/saml_users API endpoint. This endpoint will allow top-level group Owners get list of all users with SAML identity of the group.

In !190512 (merged) we want to remove saml_provider_id filter for GET /users API endpoint and offer users this endpoint instead because that saml_provider_id filter is problematic, see https://gitlab.com/gitlab-org/gitlab/-/issues/424505, and also it behaves incorrectly since !126059 (merged) - it returns not only SAML users, but also service accounts. Reed the following issue description #460261 (closed) for more details why.

Also, in !189638 (merged) we want to remove incomplete, experimental GET /groups/:id/users API endpoint; by adding this new endpoint we will be able to suggest alternative to users who use that experimental endpoint.

References

database query plans

!193748 (comment 2549193406)

Screenshots or screen recordings

Before After

How to set up and validate locally

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Bogdan Denkovych

Merge request reports

Loading