Skip to content

Attempt to migrate ci_runner_taggings table (try 2)

What does this MR do and why?

!186236 (merged) attempted to ensure that the taggings data is copied to ci_runner_taggings due to a background migration that did not work properly. However, this migration only ran if the ci_runner_taggings were empty.

If a user upgraded to GitLab 17.8.0 - 17.8.6 and added new CI runners, then the ci_runner_taggings table would not empty.

This migration attempts to relax the constraints in !186236 (merged) by performing the migration if the ci_runner_taggings table has < 50% of the entries of the runner tags from the taggings table.

This might have an unintended side effect of adding tags that were removed, but that is generally better than the alternative of missing tags altogether.

Relates to #524402 (closed)

Changelog: fixed

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Stan Hu

Merge request reports

Loading