Do not hide the projects list when user searches and result is empty
What does this MR do and why?
In Hide list of projects assigned to runner when d... (!188753 - merged) a bug was introduced where the project list in the runner details page is hidden when the user searches for a non-existing project. This MR fixes the aforementioned bug by only hiding the list when the runner data has been successfully fetched (loading === false), runner.projectCount > 1 && runner.projects.length < 1, and the user is not searching (search === '')
References
Fixes List of runner projects disappears when there a... (#541134 - closed).
Screenshots or screen recordings
| Before | After |
|---|---|
| before | after |
How to set up and validate locally
- Login with and admin (
root) - Click global search in left sidebar ("Search or go to"). Click "Admin area" menu item.
- In
/admin/runnerspage, find a project runner assigned to a project. Go to the details page of that runner - On the runner details page verify that the projects list is displayed
- Search for a non-existing project on the list
- Verify that the list is displayed with
No projects found
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Eugie Limpin