Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 36,747
    • Issues 36,747
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,496
    • Merge Requests 1,496
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !19186

You need to sign in or sign up before continuing.
Merged
Created Oct 26, 2019 by charlie ablett@cablett🔶Maintainer4 of 4 tasks completed4/4 tasks

Enable `mail_room`'s structured logging in GitLab

  • Overview 111
  • Commits 4
  • Pipelines 35
  • Changes 9

What does this MR do?

As part of #30070 (closed), this PR to allow structured logging was merged upstream, giving far more insight into what mail_room is doing behind the scenes.

This MR enables the changes in our codebase by upgrading the gem and adding the requisite config change.

  • omnibus MR: omnibus-gitlab!3719 (merged)
  • fluentd MR: gitlab-cookbooks/gitlab_fluentd!96 (merged)

Related to #35108 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

  • [-] Changelog entry
  • Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • [-] Database guides
  • [-] Separation of EE specific content

Availability and Testing

Any gem upgrade can introduce behaviour changes that might have unintended regressions. This will need to be tested to ensure it actually works too :)

  • [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • [-] Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #35108 (closed)

Edited Dec 13, 2019 by Thong Kuah
Assignee
Assign to
Reviewer
Request review from
12.6
Milestone
12.6 (Past due)
Assign milestone
Time tracking
Source branch: 32115-structured-logging-mail_room