Remove nav spacing in fullscreen on job

Austin Regneryrequested to merge
aregnery/fix-fullscreen-spacing-troubleshoot-job-log into master

What does this MR do and why?

Remove nav spacing in fullscreen on job when the navigation sidebar was visible

References

Determine Troubleshoot button position when job... (#538037) • Veethika Mishra • Backlog

Screenshots or screen recordings

Before After
GitLab_Shell_Job_131__1_ GitLab Shell Job 131.png

How to set up and validate locally

  1. Go to a failed job
  2. Make sure the navigation sidebar is visible
  3. Comment out v-if="displayStickyFooter" in app/assets/javascripts/ci/job_details/job_app.vue
  4. Comment out v-if="shouldDisplayButton" in ee/app/assets/javascripts/ci/job_details/components/root_cause_analysis_button.vue
  5. Enter fullscreen mode

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Austin Regnery

Merge request reports