Skip to content
Snippets Groups Projects

Make register job service to be resillient

Merged Kamil Trzciński requested to merge make-register-job-service-to-be-resillient into master

What does this MR do?

Make scheduler to be resilient to data integrity issues: https://gitlab.com/gitlab-org/gitlab/issues/34897.

This prevents the problem as https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/8262 https://gitlab.com/gitlab-org/gitlab/issues/34897.

The scheduler failure is considered retry able, and by default it is retried 2 extra times.

Does this MR meet the acceptance criteria?

Conformity

Edited by Kamil Trzciński

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sean McGivern resolved all threads

    resolved all threads

  • Sean McGivern
  • Sean McGivern changed milestone to %12.5

    changed milestone to %12.5

  • added 1 commit

    • 383c953f - Make `jobs/request` to be resillient

    Compare with previous version

  • Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

    Category Reviewer Maintainer
    backend Adrien Kohlbecker (@akohlbecker) Grzegorz Bizon (@grzesiek)

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Kamil Trzciński added 186 commits

    added 186 commits

    Compare with previous version

  • Fabio Pitino
  • @ayufan I only have small considerations. Looks good though!

  • assigned to @ayufan

  • added 1 commit

    • e76c9212 - Make `jobs/request` to be resillient

    Compare with previous version

  • Fabio Pitino
  • Kamil Trzciński unmarked as a Work In Progress

    unmarked as a Work In Progress

  • added 1 commit

    • 838164b9 - Make `jobs/request` to be resillient

    Compare with previous version

  • added 1 commit

    • 8345d955 - Make `jobs/request` to be resillient

    Compare with previous version

  • Kamil Trzciński resolved all threads

    resolved all threads

  • mentioned in issue #35158 (closed)

  • assigned to @fabiopitino and @smcgivern and unassigned @ayufan

  • Author Maintainer

    I resolved outstanding discussions with extra issue: #35158 (closed).

  • added 1 commit

    • ec16f95c - Make `jobs/request` to be resillient

    Compare with previous version

  • Kamil Trzciński added 337 commits

    added 337 commits

    Compare with previous version

  • Sean McGivern
  • Sean McGivern
  • added 1 commit

    • f5204bd7 - Make `jobs/request` to be resillient

    Compare with previous version

  • Fabio Pitino
  • Fabio Pitino assigned to @ayufan and unassigned @fabiopitino

    assigned to @ayufan and unassigned @fabiopitino

  • Kamil Trzciński added 23 commits

    added 23 commits

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading