Change workspace scripts volume permission to 555

Issue: Convert existing Workspaces internal script log... (#520867 - closed) • Chad Woolley • 18.0

What does this MR do and why?

• Change workspace scripts volume permission from 774 to 555. This adds other executable bit to fix problems on some workspace host environments/platforms.
• This is a fix follow-up to Convert existing Workspaces internal script log... (!182354 - merged) • Chad Woolley • 18.0
• It implements part of the fix (scripts volume, but not variables) from Grant executable permission on file contents of... (!190244 - closed) • Ashvin Sharma • 18.1.
• See !190244 (comment 2490720063) for more context.

References

Screenshots or screen recordings

See that scripts volume is 555 and variables volume is still 774:

gitlab-workspaces@workspace-4-1-cxsirh-7c84d7878f-qpmcq:/$ cd /workspace-scripts/..data
gitlab-workspaces@workspace-4-1-cxsirh-7c84d7878f-qpmcq:/workspace-scripts/..data$ ls -al
total 16
drwxr-sr-x 2 root root 120 May  7 18:45 .
drwxrwsrwt 3 root root 160 May  7 18:45 ..
-r-xr-xr-x 1 root root 365 May  7 18:45 gl-init-tools-command
-r-xr-xr-x 1 root root 435 May  7 18:45 gl-run-poststart-commands.sh
-r-xr-xr-x 1 root root 704 May  7 18:45 gl-sleep-until-container-is-running-command
-r-xr-xr-x 1 root root 574 May  7 18:45 gl-start-sshd-command
gitlab-workspaces@workspace-4-1-cxsirh-7c84d7878f-qpmcq:/workspace-scripts/..data$ cd /.workspace-data/variables/file/..data
gitlab-workspaces@workspace-4-1-cxsirh-7c84d7878f-qpmcq:/.workspace-data/variables/file/..data$ ls -al
total 12
drwxr-sr-x 2 root root 100 May  7 18:47 .
drwxrwsrwt 3 root root 140 May  7 18:47 ..
-rwxrwxr-- 1 root root 470 May  7 18:47 gl_git_credential_store.sh
-rwxrwxr-- 1 root root  26 May  7 18:47 gl_token
-rwxrwxr-- 1 root root   7 May  7 18:47 gl_workspace_reconciled_actual_state.txt

How to set up and validate locally

• Workspaces should start successfully. See Grant executable permission on file contents of... (!190244 - closed) (this comment) for more context on exactly what environments exhibit this bug.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.