Skip resolved_by validation on importing records
What does this MR do and why?
Skip resolved_by validation on importing records
A user on a GitLab instance can resolve a note and subsequently be
deleted. This results in a note with a resolved_at date, but no
corresponding user.
This note is then imported into other GitLab instances with
resolved_at intact but no resolved_by_id. This fails validation, and
the notes fail to import.
Since the invalid note is allowed on the source system, i.e. nothing prevents us from deleting users and leaving "orphaned" resolved notes, I think it makes sense to skip the validation on import.
References
Screenshots or screen recordings
Source:
Destination:
| Before | After |
|---|---|
![]() |
![]() |
How to set up and validate locally
- Create a group, and create a project within that group.
- Create an issue in the project.
- Create and resolve a discussion.
- Delete the user that resolved the discussion.
- Import the group into another using Direct Transfer.
- Observe the successfully imported note and lack of errors.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by James Nutt


