Skip to content

Add ability to make Jira comments optional

Thanks to @mdhtr who authored the original MR gitlab-foss!31731 (closed) which I got quite a few pointers from.

What does this MR do?

  • Adds the concept of "supported_event_actions" in services which is modeled closely to "supported_events". This should allow us to have even more configurable actions in the feature, for example if we want to make the remote links optional as well (not in scope of this MR).
  • Adds UI with a checkbox to enable / disable comments inside the Jira project services integration.
  • Updates the Jira integration to only add comments if the toggle "event_actions_comment" is enabled.
  • Updates the documentation with how to disable comments.

Screenshots

On this path /group/project/-/services/jira/edit

Screen_Shot_2019-10-29_at_3.06.32_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports