Skip to content

FE [Group owner bypass]: Add form elements to group settings for bypassing placeholder email confirmation

What does this MR do and why?

This frontend MR is a WIP. A follow up issue will 1) render the expiry date UI, 2) update the docs, and 3) add the suggested premium badge.

The current MR

  • Uses feature flag group_owner_placeholder_confirmation_bypass
  • Adds a checkbox to /groups/GROUP_ID/-/edit#js-permissions-settings that will allow group owners to decide to skip confirmation of placeholder reassignments for enterprise accounts.
  • Creates a date-picker for the expiry date which accompanies the above checkbox. As there is no ViewComponent version of pajamas gl-datepicker for haml, I've created a Vue component for this. However we aren't rendering the calendar at present because the backend is not available yet.

The checkbox is only rendered when:

  • the feature flag is enabled group_owner_placeholder_confirmation_bypass
  • it is a top level group
  • the instance is on gitlab.com.

When rendered, the form elements will be disabled unless the top-level group can also configure a verified domain.

Future work

This follow-up issue is for completing the feature once the following backend is done:

  • #542284 (closed) - Skip confirmation when allow bypass of placeholder user confirmation is enabled
  • #540573 (closed) - Implement "enterprise bypass of placeholder user confirmation" expiry date

References

Issue - #544024 (closed)

Screenshots or screen recordings

Before After
Screenshot 2025-04-23 at 4.17.06 PM.png Screenshot 2025-06-11 at 6.02.09 PM.png

How to set up and validate locally

In rails console enable the feature flag

Feature.enable(:group_owner_placeholder_confirmation_bypass)
  1. Make sure your instance is on the premium or ultimate plan. Instructions here
  2. Simulate Gitlab.com being true by running GITLAB_SIMULATE_SAAS=1 gdk restart
  3. Visit a group settings page. It has to be a top-level group not subgroup. Eg. http://127.0.0.1:3000/groups/flightjs/-/edit
  4. Scroll down to the 'Permissions and group features' section. You should see the checkbox under 'Placeholder user confirmation'
  5. Click the checkbox and save.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Oiza Baiye

Merge request reports

Loading