Skip to content

Support \r as line replacement in job logs

Fabio Pitino requested to merge job-log-support-mac-line-break into master

What does this MR do?

In this MR we are treating \r alone as a carriage return on the current line. This will rewind the cursor to the beginning of the current line and replace the content.

This is particularly useful for progressbars where the current line is refreshed.

The MR also contains some small refactorings to improve readability.

Related issue: #34676 (closed)

before after
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino

Merge request reports