Skip to content

Graphql: Keyset::Connection to support "attribute ASC NULLS LAST"

Brett Walker requested to merge 63778-graphql-keyset-is-null into master

What does this MR do?

Update the Keyset::Connection to directly support an ordering with the form attribute ASC NULLS LAST

This allows us to support scopes such as

  scope :order_relative_position_asc, -> { reorder(::Gitlab::Database.nulls_last_order('relative_position', 'ASC')) }

Related to: #29713 (closed) and !17788 (merged)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Brett Walker

Merge request reports