Record latencies for sidekiq failures
What does this MR do?
Previously, the sidekiq metrics middleware would not record latency and cpu duration metrics for failed sidekiq jobs.
This change does two things:
- Ensures that Sidekiq jobs that fail are also included in latency histograms.
- Adds a
job_status
label to Sidekiq latency metrics so that failed job latencies can be differentiated from successful jobs.
Closes gitlab-com/gl-infra/scalability#46 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Andrew Newdigate