Skip to content

Record latencies for sidekiq failures

Andrew Newdigate requested to merge an-sidekiq-records-failure-durations into master

What does this MR do?

Previously, the sidekiq metrics middleware would not record latency and cpu duration metrics for failed sidekiq jobs.

This change does two things:

  1. Ensures that Sidekiq jobs that fail are also included in latency histograms.
  2. Adds a job_status label to Sidekiq latency metrics so that failed job latencies can be differentiated from successful jobs.

Closes gitlab-com/gl-infra/scalability#46 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Andrew Newdigate

Merge request reports