Do not check if a user can read_build when returning job.detailed_status.details_path
What does this MR do and why?
In MR !186354 (merged), a permission check was added to the details_path method that verifies if a user can read_build before returning the path. However, this is redundant and causes issues because:
- The frontend already uses the
has_details?method to determine whether to display build status information as a link - This permission check prevents the workaround for the bug described in issue #427969
References
- Related issue: #427969 (see this discussion)
- Previous MR that introduced the check: !186354 (merged)
Screenshots or screen recordings
How to set up and validate locally
- Login as
rootand add another user as guest to thegitlab-org/gitlab-testproject. - Login as the user added as guest to the project
- Go to
/gitlab-org/gitlab-test/-/jobs - Verify that the jobs statuses are displayed as a link
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Eugie Limpin
