Fix flaky tests in base_spec file
Related to #448513 (closed)
What does this MR do?
- Fixes the flaky tests in
spec/requests/api/internal/base_spec.rb
Why?
- There were unnecessary leftover expectations from this old rate_limit_gitlab_shell_by_ip feature flag.
How to set up and validate locally
- Before cloning this branch, run the following commands on the master branch to verify flakiness:
bin/rspec ./spec/requests/api/internal/base_spec.rb` -fd
Past seeds from flaky jobs
bin/rspec ./spec/requests/api/internal/base_spec.rb -fd --seed 63433
bin/rspec ./spec/requests/api/internal/base_spec.rb -fd --seed 11345
- Clone this branch
- Repeat step 1 to make sure the tests pass
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.