Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 34,934
    • Issues 34,934
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,274
    • Merge Requests 1,274
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !18834

Open
Opened Oct 19, 2019 by Dmitry Chepurovskiy@dm3ch0 of 12 tasks completed0/12 tasks
  • Report abuse
Report abuse

WIP: Terraform module registry

  • Overview 66
  • Commits 18
  • Pipelines 18
  • Changes 6

What does this MR do?

Adds api methods that make gitlab acts as a terraform module registry.

Currently implemented only endpoints for version listing and module download

Suddenly it's just only proof of concept. And many thing still should be reworked.

Current problems:

  1. Terraform module registry service discovery is based on /.well-known/terraform.json call. So it would require gitlab-omnibus nginx config changes to make it proxy this request to ruby backend
  2. Authorization wasn't implemented yet
  3. Currently downloading is based on endpoint that download archive for specified sha. If i right understand it's not good because it would require archiving on each download. So for my opinion it would be better to make it based on artifacts.
  4. Terraform module registry has special endpoint (with auth support) <base_url>/:namespace/:name/:provider/download that returns URL where module archive could be downloaded. But suddenly terraform doesn't provide auth credentials for file download request itself, so the only way to make secure downloading is providing one-time(short-lived) download URIs or URIs with one-time(short-lived) tokens as a GET parameter.
  5. Only repositories with terraform-<provider>-<name> name format currently supported. It's made to simplify repository finding (for API handlers).
  6. One repository could contain only one terraform module

#31770 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation created/updated or follow-up review issue created
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited Aug 14, 2020 by 🤖 GitLab Bot 🤖
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!18834
Source branch: terraform-registry