Fix spec/serializers/build_details_entity_spec.rb
What does this MR do?
Don't expect the ordering
Merge request reports
Activity
added master:broken priority1 labels
@mayra-cabrera Please review? Thanks!
assigned to @mayra-cabrera
changed milestone to %12.5
mentioned in merge request !18423 (merged)
@godfat This LGTM! But I'm not sure why don't we have a pipeline?
- Resolved by Mayra Cabrera
🤔 It was so slow and I got 502 when creating this merge request. I thought it'll show later. Let me rebase.
added 11 commits
-
5828485c...a35c8f7c - 10 commits from branch
master
- a36fcc1d - Don't expect the ordering
-
5828485c...a35c8f7c - 10 commits from branch
enabled an automatic merge when the pipeline for a36fcc1d succeeds
1 Warning ⚠ Please add a throughput label to this merge request. 1 Message 📖 CHANGELOG missing: If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message. You can create one with:
bin/changelog -m 18787 "Fix spec/serializers/build_details_entity_spec.rb"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 18787 "Fix spec/serializers/build_details_entity_spec.rb"
Note: Merge requests with ~backstage, ci-build, meta do not trigger this check.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend James Edwards-Jones ( @jamedjo
)Kamil Trzciński ( @ayufan
)Generated by
🚫 Dangermentioned in commit 3cf1ab7e
mentioned in commit Dalahro/gitlab@4d1a3d31