Finalize the finish onboarding for group saml backfill
What does this MR do and why?
Finalize the finish onboarding for group saml backfill
- this only ever does work on Saas instances due to the saas feature guards around users.onboarding_in_progress the BackfillFinishOnboardingForGroupSaml class uses in the query. That is guarded in https://gitlab.com/gitlab-org/gitlab/blob/3e1bc33653f7f62fcdcc5a61ea54e35097ef805d/ee/app/services/onboarding/status_create_service.rb#L15-15.
- We can, I believe, skip the required stop here as defined in https://docs.gitlab.com/development/database/batched_background_migrations/#finalize-a-batched-background-migration as self-managed hosts are not a concern here. Please check me on this.
- The current query in postgress AI shows there is one row left https://console.postgres.ai/gitlab/gitlab-production-main/sessions/38358/commands/117688. I believe that is an outlier here and not an issue to consider this finalized. There were 4 records before this started as seen in https://console.postgres.ai/gitlab/gitlab-production-main/sessions/37767/commands/115428 and since this is only in onboarding and now only one user, we should be fine here. We will summarize more in the issue before closing.
- status:
finished✅
Changelog: other
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #522011 (closed)
